Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .editorconfig to prevent tab and space mixed #1809

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

vanduc1102
Copy link

Changes

This pull request makes the following changes:

Why

For #

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • [ ]

Steps to test this PR:

Additional information

INN Member/Labs Client requesting: (if applicable)

  • [x ] Contributor has read INN's GitHub code of conduct
  • [x ] Contributor would like to be mentioned in the release notes as: (fill in this blank)
  • [ x] Contributor agrees to the license terms of this repository.

@benlk
Copy link
Collaborator

benlk commented Oct 10, 2019

If we're going to have an editorconfig in this repository, it needs to match WordPress' code styles for PHP code and INN's own code styles: https://github.com/INN/docs/tree/master/style-guides/code

We'll also need to add guidance to our documentation in Largo and in INN/docs regarding where to learn more about getting editorconfig support for your text editor.

@benlk
Copy link
Collaborator

benlk commented Oct 10, 2019

https://github.com/WordPress/wordpress-develop/blob/master/.editorconfig is WordPress Core's editorconfig.

@benlk benlk requested a review from a team October 10, 2019 16:00
@vanduc1102
Copy link
Author

Hi @benlk , i updated the .editorconfig to https://raw.githubusercontent.com/WordPress/wordpress-develop/master/.editorconfig

for documentation updating, I'm afraid i cant do it with my current English level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants